Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-902632 connection string driven pool config #873

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Feb 23, 2024

Description

SNOW-902632 connection string driven pool config

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner February 23, 2024 17:21
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 94.13490% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 82.33%. Comparing base (85204fc) to head (db8130a).

Files Patch % Lines
...Data/Core/Session/SFSessionHttpClientProperties.cs 90.00% 7 Missing and 3 partials ⚠️
Snowflake.Data/Core/Session/SessionPool.cs 92.78% 1 Missing and 6 partials ⚠️
...ion/SessionPropertiesWithDefaultValuesExtractor.cs 96.42% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #873      +/-   ##
====================================================================
+ Coverage                             81.94%   82.33%   +0.38%     
====================================================================
  Files                                   100      104       +4     
  Lines                                  9589     9810     +221     
  Branches                                877      905      +28     
====================================================================
+ Hits                                   7858     8077     +219     
+ Misses                                 1486     1484       -2     
- Partials                                245      249       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko force-pushed the pool/SNOW-902632_connection_string_based_pool_config branch from bc68730 to 42e27b6 Compare March 4, 2024 09:48
Snowflake.Data/Core/Session/ChangedSessionBehavior.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/ChangedSessionBehavior.cs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sfc-gh-mhofman
Copy link
Collaborator

I would do one thing around _configOverriden.
When user is changing tech config of any pool I would make a copy of the initial settings.
You have all the means to make it simple - _poolConfig.
Then within the setters whether it's a new value or previous (reverted) value you can compare initial config with the new one implementing Equals on the ConnectionPoolConfig. This way if only user reverts the changes to the pool, he will get rid of the false indication in the logs that something in the pool got changed.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 052d895 into pool/SNOW-860872-connection-pool Mar 25, 2024
20 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the pool/SNOW-902632_connection_string_based_pool_config branch March 25, 2024 08:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants