-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-902632 connection string driven pool config #873
SNOW-902632 connection string driven pool config #873
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pool/SNOW-860872-connection-pool #873 +/- ##
====================================================================
+ Coverage 81.94% 82.33% +0.38%
====================================================================
Files 100 104 +4
Lines 9589 9810 +221
Branches 877 905 +28
====================================================================
+ Hits 7858 8077 +219
+ Misses 1486 1484 -2
- Partials 245 249 +4 ☔ View full report in Codecov by Sentry. |
bc68730
to
42e27b6
Compare
Snowflake.Data/Core/Session/SessionPropertiesWithDefaultValuesExtractor.cs
Show resolved
Hide resolved
Snowflake.Data/Core/Session/SessionPropertiesWithDefaultValuesExtractor.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data/Core/Session/SessionPropertiesWithDefaultValuesExtractor.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data/Core/Session/SessionPropertiesWithDefaultValuesExtractor.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/UnitTests/Session/ConnectionPoolConfigExtractorTest.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data/Core/Session/SessionPropertiesWithDefaultValuesExtractor.cs
Show resolved
Hide resolved
Snowflake.Data.Tests/IntegrationTests/ConnectionPoolCommonIT.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/UnitTests/Session/ConnectionPoolConfigExtractorTest.cs
Show resolved
Hide resolved
Snowflake.Data.Tests/UnitTests/Session/SessionPropertiesWithDefaultValuesExtractorTest.cs
Show resolved
Hide resolved
I would do one thing around _configOverriden. |
052d895
into
pool/SNOW-860872-connection-pool
Description
SNOW-902632 connection string driven pool config
Checklist
dotnet test
)