-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-990111 easy logging driver directory + Mono.Unix #868
Merged
sfc-gh-knozderko
merged 8 commits into
master
from
SNOW-990111_easy_logging_current_directory
Feb 22, 2024
Merged
SNOW-990111 easy logging driver directory + Mono.Unix #868
sfc-gh-knozderko
merged 8 commits into
master
from
SNOW-990111_easy_logging_current_directory
Feb 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pbulawa
approved these changes
Feb 19, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 84.09% 84.11% +0.02%
==========================================
Files 88 88
Lines 9387 9401 +14
Branches 883 885 +2
==========================================
+ Hits 7894 7908 +14
Misses 1260 1260
Partials 233 233 ☔ View full report in Codecov by Sentry. |
sfc-gh-mhofman
approved these changes
Feb 19, 2024
sfc-gh-mhofman
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
sfc-gh-mhofman
approved these changes
Feb 22, 2024
This reverts commit 81c644f.
sfc-gh-knozderko
deleted the
SNOW-990111_easy_logging_current_directory
branch
February 22, 2024 10:12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Easy Logging: get driver directory from executable path and use Mono.Unix
Checklist
dotnet test
)