Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-990111 easy logging driver directory + Mono.Unix #868

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Easy Logging: get driver directory from executable path and use Mono.Unix

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner February 19, 2024 15:23
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fd193e1) 84.09% compared to head (3c32d7b) 84.11%.
Report is 1 commits behind head on master.

Files Patch % Lines
Snowflake.Data/Core/Tools/EnvironmentOperations.cs 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #868      +/-   ##
==========================================
+ Coverage   84.09%   84.11%   +0.02%     
==========================================
  Files          88       88              
  Lines        9387     9401      +14     
  Branches      883      885       +2     
==========================================
+ Hits         7894     7908      +14     
  Misses       1260     1260              
  Partials      233      233              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@sfc-gh-knozderko sfc-gh-knozderko merged commit a868910 into master Feb 22, 2024
19 of 20 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-990111_easy_logging_current_directory branch February 22, 2024 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants