SNOW-798828: Target .NET Standard 2.0 #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #867 +/- ##
==========================================
+ Coverage 85.43% 85.52% +0.09%
==========================================
Files 106 106
Lines 10761 10760 -1
Branches 1029 1029
==========================================
+ Hits 9194 9203 +9
+ Misses 1318 1308 -10
Partials 249 249 ☔ View full report in Codecov by Sentry. |
sfc-gh-knozderko
requested changes
Feb 19, 2024
…nector-net into SNOW-798828-Target-NET-Standard-2.0
|
Let's plan to make a note in the readme and with the docs team that although we target Standard 2.0 we do not confirm nor run the tests on Mono/Xamarin/UWP/Unity? @sfc-gh-knozderko @sfc-gh-ext-simba-lf @sfc-gh-ext-simba-hx @sfc-gh-dszmolka |
…nector-net into SNOW-798828-Target-NET-Standard-2.0
…nector-net into SNOW-798828-Target-NET-Standard-2.0
…nector-net into SNOW-798828-Target-NET-Standard-2.0
…nector-net into SNOW-798828-Target-NET-Standard-2.0 # Conflicts: # Snowflake.Data.Tests/Util/SnowflakeDbExceptionAssert.cs # Snowflake.Data/Core/Authenticator/OktaAuthenticator.cs
sfc-gh-knozderko
requested changes
Jun 13, 2024
sfc-gh-knozderko
approved these changes
Jun 20, 2024
|
Updated readme with the new supported versions |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the target framework to .NET Standard 2.0
Checklist
dotnet test)