Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-990111 Easy Logging more tests and permission check fix #862

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner February 8, 2024 10:43
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the SNOW-990111_easy_logging_fixes branch from 71a49d7 to 291b49d Compare February 8, 2024 10:59
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (80bfb2c) 83.86% compared to head (d4fb91a) 83.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
+ Coverage   83.86%   83.91%   +0.04%     
==========================================
  Files          92       92              
  Lines        9475     9498      +23     
  Branches      879      879              
==========================================
+ Hits         7946     7970      +24     
+ Misses       1303     1302       -1     
  Partials      226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit 9da3d62 into master Feb 8, 2024
22 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-990111_easy_logging_fixes branch February 8, 2024 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants