Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-969717: Add tests for LOB #856

Merged

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Add tests for increased LOB size

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa09941) 83.75% compared to head (e8c6d66) 83.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
- Coverage   83.75%   83.74%   -0.02%     
==========================================
  Files          89       89              
  Lines        9344     9344              
  Branches      861      861              
==========================================
- Hits         7826     7825       -1     
- Misses       1295     1297       +2     
+ Partials      223      222       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review January 30, 2024 00:38
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner January 30, 2024 00:38
Copy link
Collaborator

@sfc-gh-pmotacki sfc-gh-pmotacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit e517022 into master Feb 1, 2024
19 of 20 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-969717-Increased-Max-LOB-Size-Tests branch February 1, 2024 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants