Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-990111: Add easy logging improvements #849

Merged
merged 47 commits into from
Feb 5, 2024

SNOW-990111: Move where logging is executed

dd824e6
Select commit
Loading
Failed to load commit list.
Merged

SNOW-990111: Add easy logging improvements #849

SNOW-990111: Move where logging is executed
dd824e6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 2, 2024 in 0s

83.79% (+0.04%) compared to fa09941

View this Pull Request on Codecov

83.79% (+0.04%) compared to fa09941

Details

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (fa09941) 83.75% compared to head (dd824e6) 83.79%.
Report is 1 commits behind head on master.

Files Patch % Lines
Snowflake.Data/Core/Tools/UnixOperations.cs 8.33% 11 Missing ⚠️
Snowflake.Data/Core/Session/EasyLoggingStarter.cs 93.18% 0 Missing and 3 partials ⚠️
...lake.Data/Configuration/EasyLoggingConfigFinder.cs 97.43% 0 Missing and 1 partial ⚠️
...lake.Data/Configuration/EasyLoggingConfigParser.cs 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
+ Coverage   83.75%   83.79%   +0.04%     
==========================================
  Files          89       92       +3     
  Lines        9344     9475     +131     
  Branches      861      879      +18     
==========================================
+ Hits         7826     7940     +114     
- Misses       1295     1309      +14     
- Partials      223      226       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov