Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-993556: Replace underscores with hyphen #848

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Enable automatic replacement of the underscores with hyphen with a possibility to disable it in similar way as JDBC.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner January 11, 2024 16:37
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3ccdab3) 83.42% compared to head (51d2076) 83.96%.
Report is 7 commits behind head on master.

Files Patch % Lines
Snowflake.Data/Core/Session/SFSessionProperty.cs 71.42% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
+ Coverage   83.42%   83.96%   +0.54%     
==========================================
  Files          89       89              
  Lines        9189     9313     +124     
  Branches      841      859      +18     
==========================================
+ Hits         7666     7820     +154     
+ Misses       1291     1268      -23     
+ Partials      232      225       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit a6f5261 into master Jan 12, 2024
21 of 22 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-993556-underscore branch January 12, 2024 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants