Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-984600 Avoid closing expired sessions synchronously with obtaine… #841

Merged
merged 1 commit into from
Dec 20, 2023
Merged

SNOW-984600 Avoid closing expired sessions synchronously with obtaine… #841

merged 1 commit into from
Dec 20, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

…d lock (#830)

Description

Avoid closing expired sessions synchronously with obtained lock

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko
SNOW-984600 Avoid closing expired sessions synchronously with obtaine…
fa4ee81 
…d lock (#830)

### Description
Avoid closing expired sessions synchronously with obtained lock

### Checklist
- [x] Code compiles correctly
- [x] Code is formatted according to [Coding
Conventions](../CodingConventions.md)
- [x] Created tests which fail without the change (if possible)
- [x] All tests passing (`dotnet test`)
- [x] Extended the README / documentation, if necessary
- [x] Provide JIRA issue id (if possible) or GitHub issue id in PR name
@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner December 20, 2023 12:11
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (aaa32fd) 83.48% compared to head (fa4ee81) 83.53%.

Files Patch % Lines
Snowflake.Data/Core/Session/SFSession.cs 50.00% 0 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/SessionPool.cs 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
+ Coverage   83.48%   83.53%   +0.04%     
==========================================
  Files          89       89              
  Lines        9188     9189       +1     
  Branches      841      841              
==========================================
+ Hits         7671     7676       +5     
+ Misses       1285     1282       -3     
+ Partials      232      231       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-mhofman
sfc-gh-mhofman approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed previously and coming back after revert to skip during last release

@sfc-gh-knozderko sfc-gh-knozderko merged commit 5e12bbb into master Dec 20, 2023
21 of 22 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-984600_close_expired_sessions branch December 20, 2023 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-knozderko @sfc-gh-mhofman