Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-937190 Wait for idle sessions available #840

Conversation

sfc-gh-knozderko
Copy link
Collaborator

Description

SNOW-937190 Wait for idle sessions available if session count exceeds max count

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner December 19, 2023 15:30
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (56f0b81) 81.62% compared to head (d42f4d5) 81.94%.

Files Patch % Lines
Snowflake.Data/Core/Session/SessionPool.cs 94.32% 5 Missing and 3 partials ⚠️
Snowflake.Data/Core/Session/WaitingQueue.cs 92.98% 3 Missing and 1 partial ⚠️
Snowflake.Data/Core/Session/NonWaitingQueue.cs 78.57% 3 Missing ⚠️
...wflake.Data/Core/Session/SessionOrCreationToken.cs 83.33% 0 Missing and 2 partials ⚠️
...flake.Data/Core/Session/SessionPoolEventHandler.cs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           pool/SNOW-860872-connection-pool     #840      +/-   ##
====================================================================
+ Coverage                             81.62%   81.94%   +0.32%     
====================================================================
  Files                                    93      100       +7     
  Lines                                  9334     9589     +255     
  Branches                                858      877      +19     
====================================================================
+ Hits                                   7619     7858     +239     
- Misses                                 1475     1486      +11     
- Partials                                240      245       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Snowflake.Data/Core/Session/CreateSessionToken.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/CreateSessionTokens.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/CreateSessionTokens.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/CreateSessionTokens.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/CreateSessionTokens.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/UnitTests/Session/NoOneWaitingTest.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/ICreateSessionTokens.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/ICreateSessionTokens.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/ICreateSessionTokens.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/NoOneWaiting.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/CreateSessionToken.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko force-pushed the pool/SNOW_937190_max_pool_size_reached branch from a2e641e to 1b763f5 Compare January 2, 2024 12:24
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small improvements left

Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/Util/StopWatch.cs Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/Session/SessionPool.cs Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko merged commit 85204fc into pool/SNOW-860872-connection-pool Jan 29, 2024
20 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the pool/SNOW_937190_max_pool_size_reached branch January 29, 2024 13:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants