-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-937190 Wait for idle sessions available #840
Merged
sfc-gh-knozderko
merged 35 commits into
pool/SNOW-860872-connection-pool
from
pool/SNOW_937190_max_pool_size_reached
Jan 29, 2024
Merged
SNOW-937190 Wait for idle sessions available #840
sfc-gh-knozderko
merged 35 commits into
pool/SNOW-860872-connection-pool
from
pool/SNOW_937190_max_pool_size_reached
Jan 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## pool/SNOW-860872-connection-pool #840 +/- ##
====================================================================
+ Coverage 81.62% 81.94% +0.32%
====================================================================
Files 93 100 +7
Lines 9334 9589 +255
Branches 858 877 +19
====================================================================
+ Hits 7619 7858 +239
- Misses 1475 1486 +11
- Partials 240 245 +5 ☔ View full report in Codecov by Sentry. |
sfc-gh-mhofman
requested changes
Dec 20, 2023
Snowflake.Data.Tests/UnitTests/Session/CreateSessionTokensTest.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/UnitTests/Session/CreateSessionTokenTest.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/IntegrationTests/ConnectionMultiplePoolsIT.cs
Outdated
Show resolved
Hide resolved
Snowflake.Data.Tests/IntegrationTests/ConnectionMultiplePoolsIT.cs
Outdated
Show resolved
Hide resolved
sfc-gh-knozderko
force-pushed
the
pool/SNOW_937190_max_pool_size_reached
branch
from
January 2, 2024 12:24
a2e641e
to
1b763f5
Compare
sfc-gh-mhofman
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small improvements left
Snowflake.Data/Core/Session/NonCountingSessionCreationTokenCounter.cs
Outdated
Show resolved
Hide resolved
sfc-gh-mhofman
approved these changes
Jan 29, 2024
sfc-gh-pbulawa
approved these changes
Jan 29, 2024
sfc-gh-knozderko
merged commit Jan 29, 2024
85204fc
into
pool/SNOW-860872-connection-pool
20 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-937190 Wait for idle sessions available if session count exceeds max count
Checklist
dotnet test
)