Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "SNOW-984600 Avoid closing expired sessions synchronously with… #835

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

sfc-gh-knozderko
Copy link
Collaborator

… obtained lock (#830)"

This reverts commit 645659a.

Description

Temporary reverted to release hotfix from master.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner December 15, 2023 14:06
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (49cb77d) 83.45% compared to head (8f35e5d) 83.48%.

Files Patch % Lines
Snowflake.Data/Core/Session/SFSession.cs 33.33% 0 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/SessionPool.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #835      +/-   ##
==========================================
+ Coverage   83.45%   83.48%   +0.03%     
==========================================
  Files          89       89              
  Lines        9189     9188       -1     
  Branches      841      841              
==========================================
+ Hits         7669     7671       +2     
+ Misses       1287     1285       -2     
+ Partials      233      232       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-knozderko sfc-gh-knozderko merged commit e3a44ac into master Dec 15, 2023
21 of 22 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the hotfix_prepare branch December 15, 2023 15:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants