Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-982481 Drop obsolete time sync for macos builds #833

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Dec 14, 2023

Description

Drop obsolete time sync caused by actions/runner#2996

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (645659a) 83.54% compared to head (dc2a481) 83.49%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.06%     
==========================================
  Files          89       89              
  Lines        9189     9189              
  Branches      841      841              
==========================================
- Hits         7677     7672       -5     
- Misses       1281     1285       +4     
- Partials      231      232       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review December 14, 2023 09:02
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner December 14, 2023 09:02
@sfc-gh-pfus sfc-gh-pfus merged commit 3ccdab3 into master Dec 14, 2023
21 of 22 checks passed
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-982481-time-sync branch December 14, 2023 11:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants