Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-984600 Avoid closing expired sessions synchronously with obtained lock #830

Merged
merged 8 commits into from
Dec 13, 2023

Revert "try to decrease tolarance"

4597097
Select commit
Loading
Failed to load commit list.
Merged

SNOW-984600 Avoid closing expired sessions synchronously with obtained lock #830

Revert "try to decrease tolarance"
4597097
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 13, 2023 in 0s

83.49% (-0.06%) compared to 3710031

View this Pull Request on Codecov

83.49% (-0.06%) compared to 3710031

Details

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3710031) 83.54% compared to head (4597097) 83.49%.

❗ Current head 4597097 differs from pull request most recent head 6be094a. Consider uploading reports for the commit 6be094a to get more accurate results

Files Patch % Lines
Snowflake.Data/Core/Session/SFSession.cs 50.00% 0 Missing and 2 partials ⚠️
Snowflake.Data/Core/Session/SessionPool.cs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
- Coverage   83.54%   83.49%   -0.06%     
==========================================
  Files          89       89              
  Lines        9188     9189       +1     
  Branches      841      841              
==========================================
- Hits         7676     7672       -4     
- Misses       1281     1285       +4     
- Partials      231      232       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.