SNOW-950923 fix to provide QueryID for failures during GET/PUT file operations #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #825 +/- ##
==========================================
- Coverage 84.35% 84.21% -0.14%
==========================================
Files 88 88
Lines 9336 9387 +51
Branches 874 883 +9
==========================================
+ Hits 7875 7905 +30
- Misses 1235 1251 +16
- Partials 226 231 +5 ☔ View full report in Codecov by Sentry. |
6 tasks
sfc-gh-mhofman
force-pushed
the
SNOW-950923-getqueryid-for-put-and-get
branch
from
52fcfaf to
e280fba
Compare
sfc-gh-pbulawa
approved these changes
Jan 16, 2024
sfc-gh-mhofman
force-pushed
the
SNOW-950923-getqueryid-for-put-and-get
branch
from
84bd1fe to
dbbb98a
Compare
sfc-gh-mhofman
force-pushed
the
SNOW-950923-getqueryid-for-put-and-get
branch
from
6ffaffb to
c232a6f
Compare
…found to provide QueryID (potential BCR)
…eption for put/get
sfc-gh-mhofman
force-pushed
the
SNOW-950923-getqueryid-for-put-and-get
branch
from
2e8efd1 to
8f394c8
Compare
sfc-gh-mhofman
force-pushed
the
SNOW-950923-getqueryid-for-put-and-get
branch
2 times, most recently
from
7c94eda to
cf51ef3
Compare
sfc-gh-mhofman
force-pushed
the
SNOW-950923-getqueryid-for-put-and-get
branch
3 times, most recently
from
32cc219 to
92897e3
Compare
sfc-gh-mhofman
force-pushed
the
SNOW-950923-getqueryid-for-put-and-get
branch
from
92897e3 to
7ca5fe9
Compare
sfc-gh-knozderko
approved these changes
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QueryID is super helpful when solving issues but it was not reachable when PUT/GET operation got failed at the command/exception level.
It was not available for successful scenario for PUT/GET commands as well.
This change actually introduces a new type of exception prior to the one used previously - FileNotFoundException/DirectoryNotFoundException and this previous exception is now an inner exception of SnowflakeDbException which we had to use to provide QueryId.
In rare cases (for instance when a connection was not opened) request to PUT/GET file on stage might still end up with a base Exception since QueryId won't be created in such a case.
Checklist
dotnet test)