Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-957736: Fix SnowflakeDbConnection.Dispose behaviour #807

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

The connection which is not closed properly by the user should not enter the connection pool.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner November 8, 2023 08:56
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #807 (e434e18) into master (7f73791) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #807      +/-   ##
==========================================
+ Coverage   83.54%   83.62%   +0.08%     
==========================================
  Files          89       89              
  Lines        9146     9155       +9     
  Branches      835      837       +2     
==========================================
+ Hits         7641     7656      +15     
+ Misses       1278     1272       -6     
  Partials      227      227              
Files Coverage Δ
Snowflake.Data/Client/SnowflakeDbConnection.cs 84.88% <100.00%> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 22d32dd into master Nov 9, 2023
19 of 20 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the fix-dispose branch November 9, 2023 09:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants