Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-914532: Fix variable name in ClearAllPoolsAsync #804

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

The PR renames the variable to the correct name for ClearAllPoolsAsync

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review October 26, 2023 23:16
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner October 26, 2023 23:16
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #804 (4528ac5) into master (64b638c) will increase coverage by 0.12%.
Report is 1 commits behind head on master.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
+ Coverage   83.45%   83.57%   +0.12%     
==========================================
  Files          89       89              
  Lines        9065     9073       +8     
  Branches      826      827       +1     
==========================================
+ Hits         7565     7583      +18     
+ Misses       1274     1265       -9     
+ Partials      226      225       -1     
Files Coverage Δ
Snowflake.Data/Core/Session/SessionPool.cs 90.22% <55.55%> (+1.67%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-dstempniak sfc-gh-dstempniak merged commit eb0e25d into master Oct 27, 2023
19 of 20 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-914532-Session-Pool-Close-Async branch October 27, 2023 07:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants