Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-914532: Use async for session pool finalizer #790

Merged
merged 2 commits into from
Oct 26, 2023
Merged

SNOW-914532: Use async for session pool finalizer #790

merged 2 commits into from
Oct 26, 2023

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Regarding issue 648

The PR fixes a hanging issue due to a possible deadlock by using async instead when the finalizer tries to close all the sessions in the pool

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review October 11, 2023 20:07
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner October 11, 2023 20:07
sfc-gh-dstempniak
sfc-gh-dstempniak approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit 9237a3d into master Oct 26, 2023
18 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-914532-Session-Pool-Close branch October 26, 2023 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

@sfc-gh-mhofman sfc-gh-mhofman Awaiting requested review from sfc-gh-mhofman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-lf @sfc-gh-dstempniak