Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-893834 Arrow - support for all SF types #788

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak commented Oct 9, 2023

Description

Arrow - support for all SF types

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-dstempniak sfc-gh-dstempniak marked this pull request as ready for review October 9, 2023 10:23
@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner October 9, 2023 10:23
Snowflake.Data.Tests/IntegrationTests/SFDbDataReaderIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFDbDataReaderIT.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/SFResultSet.cs Show resolved Hide resolved
Snowflake.Data/Core/SFResultSet.cs Show resolved Hide resolved
Snowflake.Data/Core/SFResultSetMetaData.cs Show resolved Hide resolved
Snowflake.Data/Core/SFResultSetMetaData.cs Show resolved Hide resolved
Snowflake.Data/Core/SFResultSetMetaData.cs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #788 (94246c8) into master (febed63) will decrease coverage by 2.01%.
The diff coverage is 82.83%.

@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
- Coverage   85.42%   83.41%   -2.01%     
==========================================
  Files          89       89              
  Lines        8733     9065     +332     
  Branches        0      826     +826     
==========================================
+ Hits         7460     7562     +102     
- Misses       1273     1276       +3     
- Partials        0      227     +227     
Files Coverage Δ
Snowflake.Data/Client/SnowflakeDbConnection.cs 84.33% <ø> (-3.62%) ⬇️
Snowflake.Data/Client/SnowflakeDbDataReader.cs 98.80% <100.00%> (+4.04%) ⬆️
Snowflake.Data/Core/BaseResultChunk.cs 78.57% <ø> (ø)
...lake.Data/Core/FileTransfer/SFFileTransferAgent.cs 72.66% <ø> (-4.32%) ⬇️
Snowflake.Data/Core/ResultSetUtil.cs 95.34% <100.00%> (-2.33%) ⬇️
Snowflake.Data/Core/SFBaseResultSet.cs 100.00% <100.00%> (+2.94%) ⬆️
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 94.28% <100.00%> (-3.58%) ⬇️
Snowflake.Data/Core/SFChunkDownloaderV2.cs 95.91% <100.00%> (-2.05%) ⬇️
Snowflake.Data/Core/SFDataConverter.cs 83.54% <100.00%> (-4.65%) ⬇️
Snowflake.Data/Core/SFResultChunk.cs 78.94% <100.00%> (ø)
... and 7 more

... and 30 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 64b638c into master Oct 19, 2023
18 of 20 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-893834 branch October 19, 2023 19:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants