SNOW-902611 move control over creation of session to session pool #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mhofman
commented
Oct 6, 2023
sfc-gh-knozderko
requested changes
Oct 9, 2023
sfc-gh-mhofman
force-pushed
the
session_pool_responsibility_for_new_sessions
branch
from
2764cf0 to
2b09dea
Compare
sfc-gh-mhofman
force-pushed
the
session_pool_responsibility_for_new_sessions
branch
from
ab61278 to
4a596bc
Compare
sfc-gh-mhofman
force-pushed
the
session_pool_responsibility_for_new_sessions
branch
from
4a596bc to
0521968
Compare
sfc-gh-knozderko
approved these changes
Oct 9, 2023
sfc-gh-mhofman
force-pushed
the
session_pool_responsibility_for_new_sessions
branch
from
0e72c99 to
4eae0c5
Compare
sfc-gh-mhofman
deleted the
session_pool_responsibility_for_new_sessions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving a code responsible for establishing a new session to the session pool class as a prerequisite step to introduction of a new connection pool implementation.
Fixed some flaky tests which were unrelated to the pool but were failing when mocked connection (with some intentional throw exception behavior) was put back to the pool by another test.
Checklist
dotnet test)