Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-902611 Extract SessionPool to a separate file + naming conventions #775

Merged
merged 1 commit into from
Sep 13, 2023
Merged

SNOW-902611 Extract SessionPool to a separate file + naming conventions #775

merged 1 commit into from
Sep 13, 2023

Conversation

sfc-gh-mhofman
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman commented Sep 12, 2023 •
edited
Loading

Description

Extracted session pool to a separate file.
Initial changes to apply naming conventions.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-mhofman sfc-gh-mhofman marked this pull request as ready for review September 13, 2023 07:50
@sfc-gh-mhofman sfc-gh-mhofman requested a review from a team as a code owner September 13, 2023 07:50
@sfc-gh-mhofman sfc-gh-mhofman merged commit 622680d into master Sep 13, 2023
18 checks passed
@sfc-gh-mhofman sfc-gh-mhofman deleted the SNOW-902611-pre-new-pool-refactoring branch September 13, 2023 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees

@sfc-gh-pbulawa sfc-gh-pbulawa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mhofman @sfc-gh-pbulawa