SNOW-893835 Arrow - support for multi-chunk results #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-pfus
reviewed
Sep 6, 2023
sfc-gh-mhofman
requested changes
Sep 6, 2023
sfc-gh-mhofman
approved these changes
Sep 11, 2023
|
I saw many "public" method changes. Are we going to mark it as a BCR? Also do we added result format changes from ARROW to JSON and vice versa like "alter session set DOTNET_RESULT_FORMAT = 'ARROW' | 'JSON'"? Default should be arrow like JDBC/ODBC/GO drivers. |
|
@sfc-gh-igarish thank you for your comment. I recreated IResultChunk interface not to do BCR. Now interface of all public methods in public classes remain the same. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Arrow - support for multi-chunk results.
Checklist
dotnet test)