Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1672654 Support for empty encryptionMaterial #1048

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak commented Oct 28, 2024

Description

If an internal stage is created with SNOWLFAKE_SSE encryption, encryptionMaterial isn't returned from Snowflake.
We need to support empty encryptionMaterial when client side encryption is disabled and isClientSideEncrypted is false.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner October 28, 2024 11:22
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (5e16693) to head (ee08529).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
+ Coverage   86.11%   86.28%   +0.16%     
==========================================
  Files         120      120              
  Lines       11628    11648      +20     
  Branches     1167     1174       +7     
==========================================
+ Hits        10013    10050      +37     
+ Misses       1332     1318      -14     
+ Partials      283      280       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dstempniak sfc-gh-dstempniak changed the title SNOW-1672654 fix for empty encryptionMaterial SNOW-1672654 Support for empty encryptionMaterial Oct 29, 2024
@sfc-gh-dstempniak sfc-gh-dstempniak merged commit d8e4b63 into master Oct 31, 2024
54 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1672654-encryptionMaterial-fix branch October 31, 2024 13:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants