Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1739483 Fix S3 exception casting and flaky tests #1042

Merged
merged 6 commits into from
Oct 24, 2024

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak commented Oct 16, 2024

Description

Fix S3 exception casting and flaky tests
We sometimes get System.InvalidCastException : Unable to cast object of type 'System.Net.Sockets.SocketException' to type 'Amazon.S3.AmazonS3Exception'.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 92.06349% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.03%. Comparing base (9ae5119) to head (deceee4).

Files with missing lines Patch % Lines
Snowflake.Data/Core/HttpUtil.cs 81.25% 2 Missing and 1 partial ⚠️
...Data/Core/FileTransfer/StorageClient/SFS3Client.cs 95.74% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
- Coverage   86.05%   86.03%   -0.03%     
==========================================
  Files         118      118              
  Lines       11493    11512      +19     
  Branches     1152     1157       +5     
==========================================
+ Hits         9890     9904      +14     
- Misses       1325     1327       +2     
- Partials      278      281       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dstempniak sfc-gh-dstempniak marked this pull request as ready for review October 16, 2024 14:00
@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner October 16, 2024 14:00
@sfc-gh-dstempniak sfc-gh-dstempniak merged commit 898a2f0 into master Oct 24, 2024
54 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1739483 branch October 24, 2024 12:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants