Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1729244: Replaced long data type with BigInteger, for TIMESTAMP_TZ and TIMESTAMP_LTZ #1037

Conversation

skornsek
Copy link

@skornsek skornsek commented Oct 9, 2024

Description

  • Replaced long data type with BigInteger, for TIMESTAMP_TZ and TIMESTAMP_LTZ. Because for large dates long data type overflow occured and values became negative.
  • I also added test cases for big dates like 9999-12-31 to SFBindUploaderTest.cs class.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test) (Some were failing before I made changes)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

#1036

…TZ and TIMESTAMP_LTZ. Also added tests for big dates like 9999-12-31
@skornsek skornsek requested a review from a team as a code owner October 9, 2024 13:22
Copy link

github-actions bot commented Oct 9, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@skornsek
Copy link
Author

skornsek commented Oct 9, 2024

I have read the CLA Document and I hereby sign the CLA

@skornsek
Copy link
Author

Fixing the same issue with more depth in PR #1038

@skornsek skornsek closed this Oct 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant