-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1629635 fix connection pool allocation #1024
Merged
sfc-gh-mhofman
merged 5 commits into
master
from
SNOW-1629635-fix-connection-pool-allocation
Sep 23, 2024
Merged
SNOW-1629635 fix connection pool allocation #1024
sfc-gh-mhofman
merged 5 commits into
master
from
SNOW-1629635-fix-connection-pool-allocation
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mhofman
force-pushed
the
SNOW-1629635-fix-connection-pool-allocation
branch
from
September 11, 2024 15:20
db9d648
to
bc32fe5
Compare
sfc-gh-mhofman
force-pushed
the
SNOW-1629635-fix-connection-pool-allocation
branch
from
September 11, 2024 15:26
bc32fe5
to
3de1edd
Compare
sfc-gh-dstempniak
approved these changes
Sep 11, 2024
sfc-gh-pbulawa
approved these changes
Sep 12, 2024
sfc-gh-knozderko
requested changes
Sep 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
- Coverage 85.75% 85.68% -0.08%
==========================================
Files 117 118 +1
Lines 11352 11400 +48
Branches 1133 1137 +4
==========================================
+ Hits 9735 9768 +33
- Misses 1337 1350 +13
- Partials 280 282 +2 ☔ View full report in Codecov by Sentry. |
sfc-gh-knozderko
approved these changes
Sep 16, 2024
sfc-gh-mhofman
deleted the
SNOW-1629635-fix-connection-pool-allocation
branch
September 23, 2024 20:56
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed connection pool manager allocation problem
Removal of exceptions related to optional connection string parameters
Checklist
dotnet test
)