Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1640968 chunk downloader fix #1022

Merged
merged 10 commits into from
Oct 9, 2024

SNOW-1640968 fix after merge

6f4620a
Select commit
Loading
Failed to load commit list.
Merged

SNOW-1640968 chunk downloader fix #1022

SNOW-1640968 fix after merge
6f4620a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 8, 2024 in 0s

85.65% (-0.14%) compared to 717a804, passed because coverage increased by 0.01% when compared to adjusted base (85.64%)

View this Pull Request on Codecov

85.65% (-0.14%) compared to 717a804, passed because coverage increased by 0.01% when compared to adjusted base (85.64%)

Details

Codecov Report

Attention: Patch coverage is 84.89583% with 29 lines in your changes missing coverage. Please review.

Project coverage is 85.65%. Comparing base (717a804) to head (6f4620a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
Snowflake.Data/Core/SFReusableChunk.cs 46.66% 16 Missing ⚠️
Snowflake.Data/Core/BaseResultChunk.cs 0.00% 7 Missing ⚠️
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 95.83% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1022      +/-   ##
==========================================
- Coverage   85.79%   85.65%   -0.14%     
==========================================
  Files         118      118              
  Lines       11451    11482      +31     
  Branches     1146     1148       +2     
==========================================
+ Hits         9824     9835      +11     
- Misses       1343     1364      +21     
+ Partials      284      283       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.