Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1488701 Enable structured types, documentation for structured types and vector type #1016

Merged
merged 13 commits into from
Oct 14, 2024
Merged

SNOW-1488701 Enable structured types, documentation for structured types and vector type #1016

merged 13 commits into from
Oct 14, 2024

Conversation

sfc-gh-knozderko
Copy link
Collaborator

@sfc-gh-knozderko sfc-gh-knozderko commented Sep 3, 2024 •
edited
Loading

Description

SNOW-1488701 Enable structured types, documentation for structured types and vector type

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-knozderko sfc-gh-knozderko requested a review from a team as a code owner September 3, 2024 10:03
sfc-gh-mkubik
sfc-gh-mkubik approved these changes Sep 3, 2024
View reviewed changes
doc/StructuredTypes.md Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.81%. Comparing base (13c4bec) to head (cef1b33).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   85.86%   85.81%   -0.06%     
==========================================
  Files         118      118              
  Lines       11486    11472      -14     
  Branches     1148     1146       -2     
==========================================
- Hits         9863     9845      -18     
- Misses       1340     1342       +2     
- Partials      283      285       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sfc-gh-pmotacki
sfc-gh-pmotacki requested changes Sep 3, 2024
View reviewed changes
doc/StructuredTypes.md Outdated Show resolved Hide resolved
doc/StructuredTypes.md Show resolved Hide resolved
@sfc-gh-knozderko sfc-gh-knozderko changed the title SNOW-1488701 Documentation for structured types SNOW-1488701 Enable structured types, documentation for structured types and vector type Oct 9, 2024
@sfc-gh-knozderko sfc-gh-knozderko merged commit 1394f53 into master Oct 14, 2024
53 of 54 checks passed
@sfc-gh-knozderko sfc-gh-knozderko deleted the SNOW-1488701_structured_types_documentation branch October 14, 2024 14:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

@sfc-gh-mhofman sfc-gh-mhofman sfc-gh-mhofman approved these changes

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-knozderko @sfc-gh-pmotacki @sfc-gh-mhofman @sfc-gh-mkubik @sfc-gh-pbulawa