Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1433638 sql trimming only for PUT/GET detection #957

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

sfc-gh-dstempniak
Copy link
Collaborator

Description

SNOW-1433638 sql trimming only for PUT/GET detection
Symbol -- cannot be treated as a string.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-dstempniak sfc-gh-dstempniak requested a review from a team as a code owner May 28, 2024 13:14
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.36%. Comparing base (abb5c4a) to head (0dacc48).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
- Coverage   84.74%   84.36%   -0.39%     
==========================================
  Files          89       89              
  Lines        9709     9707       -2     
  Branches      921      921              
==========================================
- Hits         8228     8189      -39     
- Misses       1253     1291      +38     
+ Partials      228      227       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e8-ZhixinYang
Copy link

Are you ready to merge this change?

@sfc-gh-dstempniak sfc-gh-dstempniak merged commit db8e4d5 into master Jun 7, 2024
34 of 35 checks passed
@sfc-gh-dstempniak sfc-gh-dstempniak deleted the SNOW-1433638 branch June 7, 2024 07:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants