SNOW-1433638: Symbol -- cannot be treated as a string.

[e8-ZhixinYang]

Symbol -- cannot be treated as a string.

1. What version of .NET driver are you using?
   3.1.0

2. What version of .NET framework are you using?
   .net 8.0

1)SELECT '--'; can work properly and return the result "--".

2)`
SELECT '--'

;
` encountered the following error.

SQL compilation error: parse error line 1 at position 9 near ''. syntax error line 1 at position 8 unexpected ';'.

When I was using version 2.1.0, both 1) and 2) could work properly. Do we need to make any changes?
I have checked the source code of version 3.1.0：

        private string TrimSql(string originalSql)
        {
            char[] sqlQueryBuf = originalSql.ToCharArray();
            var builder = new StringBuilder();

            // skip old c-style comment
            var idx = 0;
            var sqlQueryLen = sqlQueryBuf.Length;
            do
            {
                if (('/' == sqlQueryBuf[idx]) &&
                    (idx + 1 < sqlQueryLen) &&
                    ('*' == sqlQueryBuf[idx + 1]))
                {
                    // Search for the matching */
                    var matchingPos = originalSql.IndexOf("*/", idx + 2);
                    if (matchingPos >= 0)
                    {
                        // Found the comment closing, skip to after
                        idx = matchingPos + 2;
                    }
                }
                else if ((sqlQueryBuf[idx] == '-') &&
                         (idx + 1 < sqlQueryLen) &&
                         (sqlQueryBuf[idx + 1] == '-'))
                {
                    // Search for the new line
                    var newlinePos = originalSql.IndexOf("\n", idx + 2);

                    if (newlinePos >= 0)
                    {
                        // Found the new line, skip to after
                        idx = newlinePos + 1;
                    }
                }

                // No more characters after the closing comment character, stop trimming the query
                if (idx >= sqlQueryLen)
                {
                    break;
                }

                builder.Append(sqlQueryBuf[idx]);
                idx++;
            }
            while (idx < sqlQueryLen);

            var trimmedQuery = builder.ToString();
            trimmedQuery = trimmedQuery.Trim();
            logger.Debug("Trimmed query : " + trimmedQuery);

            return trimmedQuery;
        }

[sfc-gh-dszmolka]

thank you for reporting this error - checking it

[sfc-gh-dszmolka]

i'm not sure about the TrimSql part because it was last touched in 2.0.20, but this is definitely a confirmed bug. Last working version is 2.2.0, and the next one (3.0.0) does not work anymore and throws the error you mentioned.

We'll take a look and fix it. I'll keep this thread updated with the progress.

[sfc-gh-dszmolka]

PR under review with the fix #957

[sfc-gh-dszmolka]

Thank you for your patience here while we were undergoing a momentary code freeze period due to Summit.
Now the change is merged, and will be part of the 2024 June release, probably towards the end of month.

[sfc-gh-dszmolka]

Will update this thread once more information is known about the next upcoming major release of the .NET driver which will carry this fix.

edit: confirming with Product team; release should be available by mid-July 2024

[sfc-gh-dszmolka]

fix released with Snowflake .NET driver version v4.0.0 in July 2024