-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snow 1296059 poc nuspec #918
Conversation
This requires using Nuget.exe to be generated using the next command: nuget.exe pack snowflake.data.aws.nuspec -Exclude **
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
==========================================
- Coverage 84.64% 0.00% -84.65%
==========================================
Files 89 89
Lines 9683 9683
Branches 917 917
==========================================
- Hits 8196 0 -8196
- Misses 1259 9682 +8423
+ Partials 228 1 -227 ☔ View full report in Codecov by Sentry. |
<?xml version="1.0" encoding="utf-8"?> | ||
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"> | ||
<metadata> | ||
<id>Snowflake.Data.AWS.Dependencies</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking if we could strip this .Dependencies to make it short
<projectUrl>https://github.com/snowflakedb/snowflake-connector-net</projectUrl> | ||
<iconUrl>https://raw.githubusercontent.com/snowflakedb/snowflake-connector-net/master/Snowflake.Data/snowflake.ico</iconUrl> | ||
<description>Snowflake Connector AWS dependencies for .NET</description> | ||
<copyright>Copyright (c) 2012-2023 Snowflake Computing Inc. All rights reserved.</copyright> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 2024
Description
This only to review changes for poc
Checklist
dotnet test
)