Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow 1296059 poc nuspec #918

Closed
wants to merge 4 commits into from
+38 −4
Closed

Snow 1296059 poc nuspec #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6003572
POC to generate conditional build for exclude cloud providers.
sfc-gh-jmartinezramirez Apr 9, 2024
536a9a6
Nuspec for AWS dependencies
sfc-gh-jmartinezramirez Apr 13, 2024
773105c
Moved nuspec to providers folder
sfc-gh-jmartinezramirez Apr 17, 2024
7c0587d
Removed conditional build
sfc-gh-jmartinezramirez Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions Snowflake.Data/Snowflake.Data.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">net6.0</TargetFrameworks>
<Title>Snowflake.Data</Title>
<PackageId>Snowflake.Data</PackageId>
<Description>Snowflake Connector for .NET</Description>
<PackageLicenseUrl>https://github.com/snowflakedb/snowflake-connector-net/blob/master/LICENSE</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/snowflakedb/snowflake-connector-net</PackageProjectUrl>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
Expand All @@ -19,11 +20,24 @@
</PropertyGroup>

<ItemGroup>

<PackageReference Include="AWSSDK.S3" Version="3.7.0.4" >
<ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
<IncludeAssets>compile</IncludeAssets>
</PackageReference>
<PackageReference Include="Google.Cloud.Storage.V1" Version="4.6.0">
<ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
<IncludeAssets>compile</IncludeAssets>
</PackageReference>
<PackageReference Include="Azure.Storage.Blobs" Version="12.13.0" >
<ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
<IncludeAssets>compile</IncludeAssets>
</PackageReference>
<PackageReference Include="Azure.Storage.Common" Version="12.12.0" >
<ExcludeAssets>Runtime,Build,Native,Analyzers,BuildTransitive</ExcludeAssets>
<IncludeAssets>compile</IncludeAssets>
</PackageReference>
<PackageReference Include="Apache.Arrow" Version="14.0.2" />
<PackageReference Include="AWSSDK.S3" Version="3.7.0.4" />
<PackageReference Include="Google.Cloud.Storage.V1" Version="4.6.0" />
<PackageReference Include="Azure.Storage.Blobs" Version="12.13.0" />
<PackageReference Include="Azure.Storage.Common" Version="12.12.0" />
<PackageReference Include="Mono.Unix" Version="7.1.0-final.1.21458.1" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
<PackageReference Include="log4net" Version="2.0.12" />
Expand Down
20 changes: 20 additions & 0 deletions Snowflake.Data/providers/Snowflake.Data.AWS.Dependencies.nuspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd">
<metadata>
<id>Snowflake.Data.AWS.Dependencies</id>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking if we could strip this .Dependencies to make it short

<version>3.1.0</version>
<title>Snowflake.Data.AWS.Dependencies</title>
<authors>Snowflake</authors>
<requireLicenseAcceptance>true</requireLicenseAcceptance>
<licenseUrl>https://github.com/snowflakedb/snowflake-connector-net/blob/master/LICENSE</licenseUrl>
<projectUrl>https://github.com/snowflakedb/snowflake-connector-net</projectUrl>
<iconUrl>https://raw.githubusercontent.com/snowflakedb/snowflake-connector-net/master/Snowflake.Data/snowflake.ico</iconUrl>
<description>Snowflake Connector AWS dependencies for .NET</description>
<copyright>Copyright (c) 2012-2023 Snowflake Computing Inc. All rights reserved.</copyright>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 2024

<dependencies>
<group targetFramework="netstandard2.0">
<dependency id="AWSSDK.S3" version="3.7.0.4" exclude="Build,Analyzers" />
</group>
</dependencies>
</metadata>
</package>
Loading