Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-977565: Added start and end symbol to match full regex to bypass proxy server. #899

Merged
merged 10 commits into from
Apr 4, 2024

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented Mar 26, 2024

Description

Added start and end symbol to match string with full regex to bypass proxy server.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez requested a review from a team as a code owner March 26, 2024 23:33
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as draft March 27, 2024 00:17
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-977565-non-proxy-host-match branch 2 times, most recently from 4d059fb to af93da0 Compare March 27, 2024 17:58
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez marked this pull request as ready for review March 27, 2024 20:55
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-977565-non-proxy-host-match branch from bd0b534 to 942f56e Compare April 1, 2024 14:47
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.64%. Comparing base (dfba44e) to head (67b376f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
+ Coverage   84.59%   84.64%   +0.04%     
==========================================
  Files          89       89              
  Lines        9681     9683       +2     
  Branches      915      917       +2     
==========================================
+ Hits         8190     8196       +6     
+ Misses       1262     1259       -3     
+ Partials      229      228       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-977565-non-proxy-host-match branch from 942f56e to 85f3608 Compare April 1, 2024 16:48
Snowflake.Data/Core/HttpUtil.cs Outdated Show resolved Hide resolved
Snowflake.Data/Core/HttpUtil.cs Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-977565-non-proxy-host-match branch 2 times, most recently from 4755b62 to 1b2204b Compare April 3, 2024 18:49
README.md Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs Outdated Show resolved Hide resolved
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-977565-non-proxy-host-match branch from f6716ca to 534b642 Compare April 4, 2024 13:17
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-977565-non-proxy-host-match branch from 98249b3 to 67b376f Compare April 4, 2024 13:49
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez merged commit e092835 into master Apr 4, 2024
25 checks passed
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez deleted the SNOW-977565-non-proxy-host-match branch April 4, 2024 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants