-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-977565: Added start and end symbol to match full regex to bypass proxy server. #899
Merged
sfc-gh-jmartinezramirez
merged 10 commits into
master
from
SNOW-977565-non-proxy-host-match
Apr 4, 2024
Merged
SNOW-977565: Added start and end symbol to match full regex to bypass proxy server. #899
sfc-gh-jmartinezramirez
merged 10 commits into
master
from
SNOW-977565-non-proxy-host-match
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-977565-non-proxy-host-match
branch
2 times, most recently
from
March 27, 2024 17:58
4d059fb
to
af93da0
Compare
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-977565-non-proxy-host-match
branch
from
April 1, 2024 14:47
bd0b534
to
942f56e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 84.59% 84.64% +0.04%
==========================================
Files 89 89
Lines 9681 9683 +2
Branches 915 917 +2
==========================================
+ Hits 8190 8196 +6
+ Misses 1262 1259 -3
+ Partials 229 228 -1 ☔ View full report in Codecov by Sentry. |
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-977565-non-proxy-host-match
branch
from
April 1, 2024 16:48
942f56e
to
85f3608
Compare
sfc-gh-mhofman
requested changes
Apr 2, 2024
sfc-gh-mhofman
approved these changes
Apr 2, 2024
sfc-gh-knozderko
requested changes
Apr 3, 2024
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-977565-non-proxy-host-match
branch
2 times, most recently
from
April 3, 2024 18:49
4755b62
to
1b2204b
Compare
sfc-gh-knozderko
requested changes
Apr 4, 2024
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-977565-non-proxy-host-match
branch
from
April 4, 2024 13:17
f6716ca
to
534b642
Compare
sfc-gh-knozderko
approved these changes
Apr 4, 2024
…the proxy server.
…added to the regex to bypass the server if is different than default 80.
sfc-gh-jmartinezramirez
force-pushed
the
SNOW-977565-non-proxy-host-match
branch
from
April 4, 2024 13:49
98249b3
to
67b376f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added start and end symbol to match string with full regex to bypass proxy server.
Checklist
dotnet test
)