Apply PR suggestions

snowflakedb · Apr 4, 2024 · f6716ca · f6716ca
1 parent 1b2204b
commit f6716ca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs b/Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs
@@ -1554,7 +1554,7 @@ public void TestNonProxyHostShouldBypassProxyServer(string regexHost, string pro
             using (var conn = new SnowflakeDbConnection())
             {
                 // Arrange
-                var host = ResolveHostToUseFromTestConfig(ConnectionString);
+                var host = this.ResolveHost();
                 var nonProxyHosts = string.Format(regexHost, $"{host}");
                 conn.ConnectionString =
                     $"{ConnectionString}USEPROXY=true;PROXYHOST={proxyHost};NONPROXYHOSTS={nonProxyHosts};PROXYPORT=3128;";
@@ -1563,7 +1563,7 @@ public void TestNonProxyHostShouldBypassProxyServer(string regexHost, string pro
                 conn.Open();
 
                 // Assert
-                // If the connection is open, it indicates that the server proxy was bypassed.
+                // The connection would fail to open if the web proxy would be used because the proxy is configured to a non-existent host.
                 Assert.AreEqual(ConnectionState.Open, conn.State);
             }
         }
@@ -1585,8 +1585,7 @@ public void TestNonProxyHostShouldNotBypassProxyServer(string regexHost, string
                     $"{ConnectionString}connection_timeout=5;USEPROXY=true;PROXYHOST={proxyHost};NONPROXYHOSTS={nonProxyHosts};PROXYPORT=3128;";
 
                 // Act/Assert
-                // If the nonproxyhosts property fails to bypass the server, the proxy will be use but it will return a exception
-                // because is not configure in the testing environment so the exception is used to verify that was not bypass.
+                // The connection would fail to open if the web proxy would be used because the proxy is configured to a non-existent host.
                 var exception = Assert.Throws<SnowflakeDbException>(() => conn.Open());
 
                 // Assert

diff --git a/Snowflake.Data.Tests/SFBaseTest.cs b/Snowflake.Data.Tests/SFBaseTest.cs
@@ -147,7 +147,7 @@ public SFBaseTestAsync()
 
         protected TestConfig testConfig { get; }
 
-        protected string ResolveHostToUseFromTestConfig()
+        protected string ResolveHost()
         {
             return testConfig.host ?? $"{testConfig.account}.snowflakecomputing.com";
         }