Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1230345 Fix to support quoted values in object connection properties #891

Conversation

sfc-gh-jmartinezramirez
Copy link
Collaborator

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez commented Mar 18, 2024

Description

Fix to support quoted values in object connection properties.
Supported object properties with scaped quotes:

  • DB
  • SCHEMA
  • ROLE
  • WAREHOUSE

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

Copy link

github-actions bot commented Mar 18, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1230345-fix-issue-scaped-values-connection-string branch 3 times, most recently from 648f7cc to e425fb8 Compare March 18, 2024 15:59
Copy link
Collaborator Author

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read the CLA Document and I hereby sign the CLA

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.23%. Comparing base (a25f8c5) to head (d2903b7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
+ Coverage   84.19%   84.23%   +0.04%     
==========================================
  Files          88       88              
  Lines        9400     9402       +2     
  Branches      886      884       -2     
==========================================
+ Hits         7914     7920       +6     
+ Misses       1254     1251       -3     
+ Partials      232      231       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-jmartinezramirez
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1230345-fix-issue-scaped-values-connection-string branch from 5185b34 to f854bed Compare March 18, 2024 17:07
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1230345-fix-issue-scaped-values-connection-string branch 2 times, most recently from 6650ea3 to c6483bc Compare March 19, 2024 16:42
Rename the method to a more meaningful name.
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez force-pushed the SNOW-1230345-fix-issue-scaped-values-connection-string branch from c6483bc to d2903b7 Compare March 20, 2024 12:30
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez merged commit 8fa5df5 into master Mar 20, 2024
24 checks passed
@sfc-gh-jmartinezramirez sfc-gh-jmartinezramirez deleted the SNOW-1230345-fix-issue-scaped-values-connection-string branch March 20, 2024 13:28
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants