Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1230345: Issue 605 still not working for role, warehouse, other tokens in the connection string that may contain spaces #888

Closed
andrehartmann1968 opened this issue Mar 12, 2024 · 5 comments
Closed

SNOW-1230345: Issue 605 still not working for role, warehouse, other tokens in the connection string that may contain spaces #888

andrehartmann1968 opened this issue Mar 12, 2024 · 5 comments
Assignees
@sfc-gh-snow-drivers-warsaw-dl
Labels
bug status-triage_done Initial triage done, will be further handled by the driver team

Comments

@andrehartmann1968
Copy link

andrehartmann1968 commented Mar 12, 2024 •
edited
Loading

#605

You may have fixed this for the database, but other tokens like the role and the warehouse also support spaces in their names. Even with the current version 3.0.0 this does not work. I still cannot upgrade the usage of the package beyond 2.0.17 because of this phenomenon. Could you please re-open this and fix it once and for good?
@github-actions github-actions bot changed the title Fix released in .net driver v2.0.23 SNOW-1230345: Fix released in .net driver v2.0.23 Mar 12, 2024
@andrehartmann1968 andrehartmann1968 changed the title SNOW-1230345: Fix released in .net driver v2.0.23 SNOW-1230345: Issue 605 still not working for role, warehouse, other tokens in the connection string that may contain spaces Mar 12, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Mar 12, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added bug status-triage Issue is under initial triage labels Mar 12, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this issue Mar 12, 2024
Closed
@sfc-gh-dszmolka
Copy link
Contributor

hi and thank you for drawing our attention to this Issue - unfortunately I can confirm it still fails with the latest driver when using e.g. warehouse=\"space wh\"

we'll continue fixing this .

@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed status-triage Issue is under initial triage labels Mar 12, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-in_progress Issue is worked on by the driver team status-pr_pending_merge A PR is made and is under review and removed status-in_progress Issue is worked on by the driver team labels Mar 18, 2024
@sfc-gh-dszmolka
Copy link
Contributor

PR under review #891

@sfc-gh-dszmolka
Copy link
Contributor

PR merged and fix will be released with the next version of the driver, towards end of March

@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Mar 20, 2024
@andrehartmann1968
Copy link
Author

PR merged and fix will be released with the next version of the driver, towards end of March

Sounds spiffing, great job!

@sfc-gh-dszmolka
Copy link
Contributor

issue should be fixed now as the PR has been released with .NET driver 3.1.0. please feel free to test it out and let us know if you still see issues.

@sfc-gh-dszmolka sfc-gh-dszmolka removed the status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-snow-drivers-warsaw-dl sfc-gh-snow-drivers-warsaw-dl

Labels
bug status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrehartmann1968 @sfc-gh-dszmolka @sfc-gh-snow-drivers-warsaw-dl