pool/SNOW-902608 #2/4 new pool version v2 #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## pool/SNOW-860872-connection-pool #794 +/- ##
====================================================================
+ Coverage 83.56% 83.80% +0.24%
====================================================================
Files 89 91 +2
Lines 9155 9313 +158
Branches 837 857 +20
====================================================================
+ Hits 7650 7805 +155
- Misses 1278 1279 +1
- Partials 227 229 +2
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
sfc-gh-mhofman
changed the title
sfc-gh-mhofman
changed the title
sfc-gh-mhofman
changed the title
sfc-gh-mhofman
force-pushed
the
pool/SNOW-902608-new-pool-version
branch
6 times, most recently
from
0612dc5 to
55a764a
Compare
sfc-gh-mhofman
commented
Oct 20, 2023
sfc-gh-mhofman
commented
Oct 31, 2023
sfc-gh-mhofman
force-pushed
the
pool/SNOW-902608-new-pool-version
branch
from
5d4c5af to
259e67a
Compare
Snowflake.Data.Tests/UnitTests/ConnectionPoolManagerSwitchTest.cs
Outdated
Show resolved
Hide resolved
|
The code is inactive and there is no public api to enable the new pool for now. |
Snowflake.Data.Tests/UnitTests/ConnectionPoolManagerSwitchTest.cs
Outdated
Show resolved
Hide resolved
sfc-gh-mhofman
force-pushed
the
pool/SNOW-902608-new-pool-version
branch
from
5f71f0e to
d309552
Compare
- removed singleton pattern from SessionPool; introduced new interface for ConnectionManager; split tests of ConnectionPool and some cleanup in the classes SNOW-902608 - new Connection Pool Manager version implementation - unit tests for new pool; introduction of SessionFactory for unit testing of new pool manager and session pooling - integration tests for two versions of Connection Pool - ClearAllPools removes entire SessionPools collection in new pool - Fixes to flaky tests of connection pool
sfc-gh-mhofman
force-pushed
the
pool/SNOW-902608-new-pool-version
branch
from
d309552 to
c401f2c
Compare
sfc-gh-mhofman
changed the base branch from
master
to
pool/SNOW-860872-connection-pool
sfc-gh-knozderko
approved these changes
Nov 9, 2023
sfc-gh-mhofman
merged commit af36804
into
pool/SNOW-860872-connection-pool
19 of 20 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connection Pool v2
Checklist
dotnet test)