Naming suggestions from review

Snowflake.Data.Tests/IntegrationTests/SFConnectionPoolIT.cs

@@ -233,7 +233,6 @@ public void TestConnectionPoolExpirationWorks()
             // not just the connections created after the new setting,
             // so expected result should be 0
             Assert.AreEqual(0, SnowflakeDbConnectionPool.GetPool(ConnectionString).GetCurrentPoolSize());
-            SnowflakeDbConnectionPool.SetPooling(false);
         }
 
         [Test]

Snowflake.Data.Tests/UnitTests/ConnectionPoolManagerTest.cs

@@ -46,8 +46,8 @@ public void TestPoolManagerReturnsSessionPoolForGivenConnectionString()
             var sessionPool = _connectionPoolManager.GetPool(ConnectionString1, _password);
 
             // Assert
-            Assert.AreEqual(ConnectionString1, sessionPool._connectionString);
-            Assert.AreEqual(_password, sessionPool._password);
+            Assert.AreEqual(ConnectionString1, sessionPool.ConnectionString);
+            Assert.AreEqual(_password, sessionPool.Password);
         }
 
         [Test]
@@ -76,8 +76,8 @@ public void TestDifferentPoolsAreReturnedForDifferentConnectionStrings()
 
             // Assert
             Assert.AreNotSame(sessionPool1, sessionPool2);
-            Assert.AreEqual(ConnectionString1, sessionPool1._connectionString);
-            Assert.AreEqual(ConnectionString2, sessionPool2._connectionString);
+            Assert.AreEqual(ConnectionString1, sessionPool1.ConnectionString);
+            Assert.AreEqual(ConnectionString2, sessionPool2.ConnectionString);
         }
 
 

Snowflake.Data.Tests/UnitTests/ConnectionPoolManagerSwitchTest.cs → Snowflake.Data.Tests/UnitTests/SnowflakeDbConnectionPoolTest.cs

@@ -4,7 +4,7 @@
 
 namespace Snowflake.Data.Tests.UnitTests
 {
-    public class ConnectionPoolManagerSwitchTest
+    public class SnowflakeDbConnectionPoolTest
     {
         private readonly string _connectionString1 = "database=D1;warehouse=W1;account=A1;user=U1;password=P1;role=R1;";
         private readonly string _connectionString2 = "database=D2;warehouse=W2;account=A2;user=U2;password=P2;role=R2;";
@@ -23,4 +23,3 @@ public void TestRevertPoolToPreviousVersion()
         }
     }
 }
-

Snowflake.Data/Core/Session/ConnectionCacheManager.cs

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2012-2021 Snowflake Computing Inc. All rights reserved.
+ * Copyright (c) 2012-2023 Snowflake Computing Inc. All rights reserved.
  */
 
 using System.Security;

Snowflake.Data/Core/Session/ConnectionPoolManager.cs

@@ -103,13 +103,9 @@ public int GetCurrentPoolSize()
         public bool SetPooling(bool poolingEnabled)
         {
             s_logger.Debug("ConnectionPoolManager::SetPooling for all pools");
-            bool switched = true;
-            foreach (var pool in _pools.Values)
-            {
-                if (!pool.SetPooling(poolingEnabled))
-                    switched = false;
-            }
-            return switched;
+            return _pools.Values
+                .Select(pool => pool.SetPooling(poolingEnabled))
+                .All(setPoolingResult => setPoolingResult);
         }
 
         public bool GetPooling() 

Snowflake.Data/Core/Session/SFSession.cs

@@ -68,8 +68,8 @@ public class SFSession
         private readonly EasyLoggingStarter _easyLoggingStarter = EasyLoggingStarter.Instance;
 
         private long _startTime = 0;
-        internal readonly string ConnectionString;
-        internal readonly SecureString Password;
+        internal string ConnectionString { get; }
+        internal SecureString Password { get; }
 
         private QueryContextCache _queryContextCache = new QueryContextCache(_defaultQueryContextCacheSize);
 

Snowflake.Data/Core/Session/SessionPool.cs

@@ -17,17 +17,17 @@ sealed class SessionPool : IDisposable
     {
         private static readonly SFLogger s_logger = SFLoggerFactory.GetLogger<SessionPool>();
         private static readonly object s_sessionPoolLock = new object();
+        private static ISessionFactory s_sessionFactory = new SessionFactory();
 
         private readonly List<SFSession> _idleSessions;
         private int _maxPoolSize;
         private long _timeout;
         private const int MaxPoolSize = 10;
         private const long Timeout = 3600;
-        internal string _connectionString;
-        internal SecureString _password;
+        internal string ConnectionString { get; }
+        internal SecureString Password { get; }
         private bool _pooling = true;
         private bool _allowExceedMaxPoolSize = true;
-        private static ISessionFactory s_sessionFactory = new SessionFactory();
 
         private SessionPool()
         {
@@ -41,8 +41,8 @@ private SessionPool()
 
         private SessionPool(string connectionString, SecureString password) : this()
         {
-            _connectionString = connectionString;
-            _password = password;
+            ConnectionString = connectionString;
+            Password = password;
             _allowExceedMaxPoolSize = false; // TODO: SNOW-937190
         }
 
@@ -104,10 +104,10 @@ internal Task<SFSession> GetSessionAsync(string connStr, SecureString password,
             return session != null ? Task.FromResult(session) : NewSessionAsync(connStr, password, cancellationToken);
         }
 
-        internal SFSession GetSession() => GetSession(_connectionString, _password);
+        internal SFSession GetSession() => GetSession(ConnectionString, Password);
 
         internal Task<SFSession> GetSessionAsync(CancellationToken cancellationToken) =>
-            GetSessionAsync(_connectionString, _password, cancellationToken);
+            GetSessionAsync(ConnectionString, Password, cancellationToken);
 
         private SFSession GetIdleSession(string connStr)
         {