Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-723810: Add coverage for StorageClient #785

Merged
merged 2 commits into from
Oct 18, 2023
Merged

SNOW-723810: Add coverage for StorageClient #785

merged 2 commits into from
Oct 18, 2023

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf commented Oct 6, 2023 •
edited
Loading

Description

Regarding issue 113

The PR removes unused code in the StorageClient

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf marked this pull request as ready for review October 11, 2023 20:14
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf requested a review from a team as a code owner October 11, 2023 20:14
sfc-gh-dstempniak
sfc-gh-dstempniak approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-dstempniak sfc-gh-dstempniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment, overall LGTM

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #785 (9a9eec0) into master (6feb3cb) will increase coverage by 0.16%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
+ Coverage   84.99%   85.15%   +0.16%     
==========================================
  Files          89       89              
  Lines        8677     8733      +56     
==========================================
+ Hits         7375     7437      +62     
+ Misses       1302     1296       -6

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf merged commit 459b170 into master Oct 18, 2023
20 checks passed
@sfc-gh-ext-simba-lf sfc-gh-ext-simba-lf deleted the SNOW-723810-Add-Coverage-StorageClient branch October 18, 2023 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dstempniak sfc-gh-dstempniak sfc-gh-dstempniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-lf @sfc-gh-dstempniak