Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1629635 fix connection pool allocation #1024

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

sfc-gh-mhofman
Copy link
Collaborator

@sfc-gh-mhofman sfc-gh-mhofman commented Sep 11, 2024

Description

Fixed connection pool manager allocation problem
Removal of exceptions related to optional connection string parameters

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-mhofman sfc-gh-mhofman requested a review from a team as a code owner September 11, 2024 14:56
@sfc-gh-mhofman sfc-gh-mhofman force-pushed the SNOW-1629635-fix-connection-pool-allocation branch from db9d648 to bc32fe5 Compare September 11, 2024 15:20
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 93.29897% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.68%. Comparing base (aef4d3a) to head (02aedf2).

Files with missing lines Patch % Lines
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 95.83% 3 Missing and 3 partials ⚠️
Snowflake.Data/Core/Tools/Diagnostics.cs 87.50% 3 Missing and 2 partials ⚠️
Snowflake.Data/Client/SnowflakeDbConnectionPool.cs 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1024      +/-   ##
==========================================
- Coverage   85.75%   85.68%   -0.08%     
==========================================
  Files         117      118       +1     
  Lines       11352    11400      +48     
  Branches     1133     1137       +4     
==========================================
+ Hits         9735     9768      +33     
- Misses       1337     1350      +13     
- Partials      280      282       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-mhofman sfc-gh-mhofman merged commit 77410c7 into master Sep 23, 2024
51 of 52 checks passed
@sfc-gh-mhofman sfc-gh-mhofman deleted the SNOW-1629635-fix-connection-pool-allocation branch September 23, 2024 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants