Log exceptions when operating with token cache

snowflakedb · Dec 13, 2024 · f5e1862 · f5e1862
1 parent ef7b2ee
commit f5e1862
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerFileImpl.cs b/Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerFileImpl.cs
@@ -136,6 +136,11 @@ public string GetCredentials(string key)
                         }
                     }
                 }
+                catch (Exception exception)
+                {
+                    s_logger.Error("Failed to get credentials", exception);
+                    throw;
+                }
                 finally
                 {
                     ReleaseLock();
@@ -166,6 +171,11 @@ public void RemoveCredentials(string key)
                         WriteToJsonFile(JsonConvert.SerializeObject(credentials));
                     }
                 }
+                catch (Exception exception)
+                {
+                    s_logger.Error("Failed to remove credentials", exception);
+                    throw;
+                }
                 finally
                 {
                     ReleaseLock();
@@ -192,6 +202,11 @@ public void SaveCredentials(string key, string token)
                     string jsonString = JsonConvert.SerializeObject(credentials);
                     WriteToJsonFile(jsonString);
                 }
+                catch (Exception exception)
+                {
+                    s_logger.Error("Failed to save credentials", exception);
+                    throw;
+                }
                 finally
                 {
                     ReleaseLock();

diff --git a/Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerWindowsNativeImpl.cs b/Snowflake.Data/Core/CredentialManager/Infrastructure/SFCredentialManagerWindowsNativeImpl.cs
@@ -31,6 +31,11 @@ public string GetCredentials(string key)
             {
                 success = CredRead(key, 1 /* Generic */, 0, out nCredPtr);
             }
+            catch (Exception exception)
+            {
+                s_logger.Error($"Failed to get credentials", exception);
+                throw;
+            }
             finally
             {
                 _lock.ExitReadLock();
@@ -58,6 +63,11 @@ public void RemoveCredentials(string key)
             {
                 success = CredDelete(key, 1 /* Generic */, 0);
             }
+            catch (Exception exception)
+            {
+                s_logger.Error($"Failed to remove credentials", exception);
+                throw;
+            }
             finally
             {
                 _lock.ExitWriteLock();
@@ -89,6 +99,11 @@ public void SaveCredentials(string key, string token)
             {
                 CredWrite(ref credential, 0);
             }
+            catch (Exception exception)
+            {
+                s_logger.Error($"Failed to save credentials", exception);
+                throw;
+            }
             finally
             {
                 _lock.ExitWriteLock();