Merge pull request #374 from snowflakedb/prep-1.2.8

SNOW-460679 Bump version from 1.2.7 to 1.2.8
snowflakedb · Sep 14, 2021 · bd1742f · bd1742f
2 parents 1faf951 + a09c058
commit bd1742f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/Snowflake.Data/Core/Authenticator/IAuthenticator.cs b/Snowflake.Data/Core/Authenticator/IAuthenticator.cs
@@ -90,14 +90,14 @@ protected void Login()
         }
 
         /// <summary>
-        /// Specialized authenticator data to add to the login request. 
+        /// Specialized authenticator data to add to the login request.
         /// </summary>
         /// <param name="data">The login request data to update.</param>
         protected abstract void SetSpecializedAuthenticatorData(ref LoginRequestData data);
 
         /// <summary>
         /// Builds a simple login request. Each authenticator will fill the Data part with their
-        /// specialized information. The common Data attributes are already filled (clientAppId, 
+        /// specialized information. The common Data attributes are already filled (clientAppId,
         /// ClienAppVersion...).
         /// </summary>
         /// <returns>A login request to send to the server.</returns>
@@ -181,9 +181,8 @@ internal static IAuthenticator GetAuthenticator(SFSession session)
 
                 return new OAuthAuthenticator(session);
             }
-            // Okta would provide a url of form: https://xxxxxx.okta.com or https://xxxxxx.oktapreview.com
-            else if ((type.EndsWith("okta.com") || type.EndsWith("oktapreview.com") )
-                     && type.StartsWith("https://"))
+            // Okta would provide a url of form: https://xxxxxx.okta.com or https://xxxxxx.oktapreview.com or https://vanity.url/snowflake/okta
+            else if (type.Contains("okta") && type.StartsWith("https://"))
             {
                 return new OktaAuthenticator(session, type);
             }

diff --git a/Snowflake.Data/Snowflake.Data.csproj b/Snowflake.Data/Snowflake.Data.csproj
@@ -12,7 +12,7 @@
     <Product>Snowflake Connector for .NET</Product>
     <Authors>howryu, tchen</Authors>
     <Copyright>Copyright (c) 2012-2019 Snowflake Computing Inc. All rights reserved.</Copyright>
-    <Version>1.2.7</Version>
+    <Version>1.2.8</Version>
     <DebugType>Full</DebugType>
   </PropertyGroup>