SNOW-723810: Add coverage for RestRequest

snowflakedb · Oct 6, 2023 · ad92e98 · ad92e98
1 parent 6feb3cb
commit ad92e98
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/Snowflake.Data.Tests/UnitTests/SFOktaTest.cs b/Snowflake.Data.Tests/UnitTests/SFOktaTest.cs
@@ -69,5 +69,54 @@ public void TestWrongPostbackUrl()
                 Assert.AreEqual(SFError.IDP_SAML_POSTBACK_INVALID.GetAttribute<SFErrorAttr>().errorCode, e.ErrorCode);
             }
         }
+
+        [Test]
+        public void TestLoginRequestToString()
+        {
+            string expectedOktaAccount = "mockOktaAccount";
+            string expectedOktaUser = "mockOktaUser";
+            string expectedOktaUrl = "mockOktaUrl";
+
+            LoginRequestClientEnv loginRequestClientEnv = new LoginRequestClientEnv();
+            LoginRequest loginRequest = new LoginRequest()
+            {
+                data = new LoginRequestData()
+                {
+                    loginName = expectedOktaUser,
+                    accountName = expectedOktaAccount,
+                    clientAppVersion = SFEnvironment.DriverVersion,
+                    clientEnv = loginRequestClientEnv,
+                    Authenticator = expectedOktaUrl,
+                }
+            };
+
+            Assert.AreEqual($"LoginRequest {{data: LoginRequestData {{ClientAppVersion: {SFEnvironment.DriverVersion},\n " +
+                $"AccountName: {expectedOktaAccount},\n " +
+                $"loginName: {expectedOktaUser},\n " +
+                $"ClientEnv: {{ " +
+                $"APPLICATION: , " +
+                $"OS_VERSION: , " +
+                $"NET_RUNTIME: , " +
+                $"NET_VERSION: , " +
+                $"INSECURE_MODE:  }},\n " +
+                $"authenticator: {expectedOktaUrl} }} }}",
+                loginRequest.ToString());
+        }
+
+        [Test]
+        public void TestAuthenticatorRequestToString()
+        {
+            string expectedOktaAccount = "mockOktaAccount";
+            AuthenticatorRequest authenticatorRequest = new AuthenticatorRequest()
+            {
+                Data = new AuthenticatorRequestData()
+                {
+                    AccountName = expectedOktaAccount,
+                }
+            };
+
+            Assert.AreEqual($"AuthenticatorRequest {{data: AuthenticatorRequestData {{ACCOUNT_NAME: {expectedOktaAccount} }} }}",
+                authenticatorRequest.ToString());
+        }
     }
 }
diff --git a/Snowflake.Data/Core/RestRequest.cs b/Snowflake.Data/Core/RestRequest.cs
@@ -198,7 +198,7 @@ class AuthenticatorRequestData
 
         public override string ToString()
         {
-            return String.Format("AuthenticatorRequestData {{ACCOUNT_NANM: {0} }}",
+            return String.Format("AuthenticatorRequestData {{ACCOUNT_NAME: {0} }}",
                 AccountName.ToString());
         }
     }