Skip to content

Commit

Permalink
SNOW-1736920 fix log messages
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-dstempniak committed Oct 15, 2024
1 parent 4e5b95d commit 89c2848
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ private SFFileMetadata HandleFileHeaderErrForGeneratedUrls(WebException ex, SFFi
/// <returns>File Metadata</returns>
private SFFileMetadata HandleUploadFileErr(WebException ex, SFFileMetadata fileMetadata)
{
Logger.Error("Failed to upload file. ", ex);
Logger.Error("Failed to upload file: " + ex.Message);

fileMetadata.lastError = ex;

Expand Down
4 changes: 2 additions & 2 deletions Snowflake.Data/Core/SFStatement.cs
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ internal async Task<SFBaseResultSet> ExecuteAsync(int timeout, string sql, Dicti
}
catch (Exception e)
{
logger.Warn($"Exception encountered trying to upload binds to stage. Attaching binds in payload instead.", e);
logger.Warn("Exception encountered trying to upload binds to stage. Attaching binds in payload instead. Exception: " + e.Message);
}

Check warning on line 390 in Snowflake.Data/Core/SFStatement.cs

View check run for this annotation

Codecov / codecov/patch

Snowflake.Data/Core/SFStatement.cs#L389-L390

Added lines #L389 - L390 were not covered by tests
finally
{
Expand Down Expand Up @@ -538,7 +538,7 @@ private SFBaseResultSet ExecuteSqlOtherThanPutGet(int timeout, string sql, Dicti
}
catch (Exception e)
{
logger.Warn( $"Exception encountered trying to upload binds to stage. Attaching binds in payload instead.", e);
logger.Warn("Exception encountered trying to upload binds to stage. Attaching binds in payload instead. Exception: " + e.Message);
}

Check warning on line 542 in Snowflake.Data/Core/SFStatement.cs

View check run for this annotation

Codecov / codecov/patch

Snowflake.Data/Core/SFStatement.cs#L541-L542

Added lines #L541 - L542 were not covered by tests
finally
{
Expand Down

0 comments on commit 89c2848

Please sign in to comment.