SNOW-893834 fixes after CR, enabling ARROW tests

snowflakedb · Nov 7, 2023 · 6260a69 · 6260a69
1 parent a737045
commit 6260a69
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/Snowflake.Data.Tests/IntegrationTests/SFDbDataReaderIT.cs b/Snowflake.Data.Tests/IntegrationTests/SFDbDataReaderIT.cs
@@ -15,8 +15,7 @@
 
 namespace Snowflake.Data.Tests.IntegrationTests
 {
-    // TODO: enable tests for Arrow
-    //[TestFixture(ResultFormat.ARROW)]
+    [TestFixture(ResultFormat.ARROW)]
     [TestFixture(ResultFormat.JSON)]
     class SFDbDataReaderIT : SFBaseTest
     {
@@ -201,7 +200,6 @@ public void TestDateOutputFormat()
                     IDataReader reader = cmd.ExecuteReader();
 
                     ValidateResultFormat(reader);
-
                     Assert.IsTrue(reader.Read());
                     Assert.AreEqual("05/17/2013", reader.GetString(0));
 
@@ -637,12 +635,11 @@ public void TestGetByte()
                 // Act
                 using (IDataReader reader = cmd.ExecuteReader())
                 {
-                    ValidateResultFormat(reader);
-
                     int index = 0;
                     while (reader.Read())
                     {
                         // Assert
+                        ValidateResultFormat(reader);
                         Assert.AreEqual(testBytes[index++], reader.GetByte(0));
                     }
                 }
@@ -815,9 +812,8 @@ public void TestGetChar()
                 // Act
                 using (IDataReader reader = cmd.ExecuteReader())
                 {
-                    ValidateResultFormat(reader);
-
                     // Assert
+                    ValidateResultFormat(reader);
                     Assert.IsTrue(reader.Read());
                     Assert.AreEqual(testChar, reader.GetChar(0));
                 }
@@ -1003,9 +999,8 @@ public void TestGetDataTypeName()
                 // Act
                 using (DbDataReader reader = (DbDataReader)cmd.ExecuteReader())
                 {
-                    ValidateResultFormat(reader);
-
                     // Assert
+                    ValidateResultFormat(reader);
                     Assert.IsTrue(reader.Read());
                     Assert.AreEqual("TEXT", reader.GetDataTypeName(0));
                     Assert.AreEqual("BINARY", reader.GetDataTypeName(1));