SNOW-1640968 Dispose http response in Okta Authenticator (#1010)

snowflakedb · Aug 28, 2024 · 60c2f2b · 60c2f2b
1 parent adac81a
commit 60c2f2b
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 15 deletions.
diff --git a/Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs b/Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs
@@ -839,7 +839,7 @@ public void TestOktaConnectionUntilMaxTimeout()
             {
                 TokenUrl = $"{oktaUrl}/api/v1/sessions?additionalFields=cookieToken",
                 SSOUrl = $"{oktaUrl}/app/testaccount/sso/saml",
-                ResponseContent = new StringContent("<form=error}"),
+                ResponseContent = "<form=error}",
                 MaxRetryCount = expectedMaxRetryCount,
                 MaxRetryTimeout = expectedMaxConnectionTimeout
             };
@@ -2191,7 +2191,7 @@ public void TestAsyncOktaConnectionUntilMaxTimeout()
             {
                 TokenUrl = $"{oktaUrl}/api/v1/sessions?additionalFields=cookieToken",
                 SSOUrl = $"{oktaUrl}/app/testaccount/sso/saml",
-                ResponseContent = new StringContent("<form=error}"),
+                ResponseContent = "<form=error}",
                 MaxRetryCount = expectedMaxRetryCount,
                 MaxRetryTimeout = expectedMaxConnectionTimeout
             };

diff --git a/Snowflake.Data.Tests/Mock/MockOkta.cs b/Snowflake.Data.Tests/Mock/MockOkta.cs
@@ -15,7 +15,7 @@ class MockOktaRestRequester : IMockRestRequester
     {
         public string TokenUrl { get; set; }
         public string SSOUrl { get; set; }
-        public StringContent ResponseContent { get; set; }
+        public string ResponseContent { get; set; }
         public int MaxRetryCount { get; set; }
         public int MaxRetryTimeout { get; set; }
 
@@ -32,7 +32,7 @@ public Task<T> GetAsync<T>(IRestRequest request, CancellationToken cancellationT
         public Task<HttpResponseMessage> GetAsync(IRestRequest request, CancellationToken cancellationToken)
         {
             var response = new HttpResponseMessage(System.Net.HttpStatusCode.OK);
-            response.Content = ResponseContent;
+            response.Content = new StringContent(ResponseContent);
             response.Content.Headers.Add(OktaAuthenticator.RetryCountHeader, MaxRetryCount.ToString());
             response.Content.Headers.Add(OktaAuthenticator.TimeoutElapsedHeader, MaxRetryTimeout.ToString());
             return Task.FromResult(response);