Skip to content

Commit

Permalink
Fix review notes
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-knozderko committed Jun 12, 2024
1 parent f7ba608 commit 53f74be
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: DotNet Build and Test
# Triggers the workflow on push or pull request events but only for the master branch
on:
push:
branches: [ master, pool/SNOW-860872-connection-pool ]
branches: [ master ]
pull_request:
branches: [ master, pool/SNOW-860872-connection-pool ]
branches: [ master ]
workflow_dispatch:
inputs:
logLevel:
Expand Down
4 changes: 2 additions & 2 deletions Snowflake.Data/Core/Session/ConnectionPoolManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public bool GetPooling()

public SessionPool GetPool(string connectionString, SecureString password)
{
s_logger.Debug($"ConnectionPoolManager::GetPool");
s_logger.Debug("ConnectionPoolManager::GetPool with connection string and secure password");
var poolKey = GetPoolKey(connectionString, password);

if (_pools.TryGetValue(poolKey, out var item))
Expand All @@ -147,7 +147,7 @@ public SessionPool GetPool(string connectionString, SecureString password)

public SessionPool GetPool(string connectionString)
{
s_logger.Debug($"ConnectionPoolManager::GetPool");
s_logger.Debug("ConnectionPoolManager::GetPool with connection string");
return GetPool(connectionString, null);
}

Expand Down

0 comments on commit 53f74be

Please sign in to comment.