SNOW-902611 bugfixes for open failures

snowflakedb · Oct 6, 2023 · 52d4038 · 52d4038
1 parent 3642b96
commit 52d4038
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/Snowflake.Data/Client/SnowflakeDbConnection.cs b/Snowflake.Data/Client/SnowflakeDbConnection.cs
@@ -257,9 +257,18 @@ public override void Open()
             }
             catch (Exception e)
             {
+                // Otherwise when Dispose() is called, the close request would timeout.
                 _connectionState = ConnectionState.Closed;
-                logger.Error(e.Message);
-                throw;
+                logger.Error("Unable to connect: ", e);
+                if (e is SnowflakeDbException)
+                {
+                    throw;
+                }
+                throw new SnowflakeDbException(
+                        e,
+                        SnowflakeDbException.CONNECTION_FAILURE_SSTATE,
+                        SFError.INTERNAL_ERROR,
+                        "Unable to connect. " + e.Message);
             }
         }
 

diff --git a/Snowflake.Data/Core/Session/SessionPool.cs b/Snowflake.Data/Core/Session/SessionPool.cs
@@ -164,20 +164,17 @@ internal Task<SFSession> NewSessionAsync(String connectionString, SecureString p
                     .OpenAsync(cancellationToken)
                     .ContinueWith(previousTask =>
                     {
-                        if (previousTask.IsCanceled)
-                            cancellationToken.ThrowIfCancellationRequested();
-
                         if (previousTask.IsFaulted && previousTask.Exception != null)
                             throw previousTask.Exception;
 
                         if (previousTask.IsFaulted)
                             throw new SnowflakeDbException(
                                 SnowflakeDbException.CONNECTION_FAILURE_SSTATE,
                                 SFError.INTERNAL_ERROR,
-                                "Async open on connection failure");
+                                "Failure while opening session async");
 
                         return session;
-                    }, cancellationToken);
+                    }, TaskContinuationOptions.NotOnCanceled);
             }
             catch (Exception e)
             {