SNOW-817091: Fix session closing issue

snowflakedb · Mar 9, 2024 · 3810211 · 3810211
1 parent 812cba0
commit 3810211
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/Snowflake.Data/Client/SnowflakeDbConnection.cs b/Snowflake.Data/Client/SnowflakeDbConnection.cs
@@ -153,8 +153,8 @@ public override void Close()
             {
                 var transactionRollbackStatus = SnowflakeDbConnectionPool.GetPooling() ? TerminateTransactionForDirtyConnectionReturningToPool() : TransactionRollbackStatus.Undefined;
 
-                if (CanReuseSession(transactionRollbackStatus) &&
-                    SfSession.StillRunningAsyncQueries() &&
+                if ((CanReuseSession(transactionRollbackStatus) ||
+                    SfSession.StillRunningAsyncQueries()) &&
                     SnowflakeDbConnectionPool.AddSession(SfSession)
                     )
                 {
@@ -194,8 +194,8 @@ public virtual async Task CloseAsync(CancellationToken cancellationToken)
                 {
                     var transactionRollbackStatus = SnowflakeDbConnectionPool.GetPooling() ? TerminateTransactionForDirtyConnectionReturningToPool() : TransactionRollbackStatus.Undefined;
 
-                    if (CanReuseSession(transactionRollbackStatus) &&
-                        await SfSession.StillRunningAsyncQueriesAsync(cancellationToken).ConfigureAwait(false) &&
+                    if ((CanReuseSession(transactionRollbackStatus) ||
+                        await SfSession.StillRunningAsyncQueriesAsync(cancellationToken).ConfigureAwait(false)) &&
                         SnowflakeDbConnectionPool.AddSession(SfSession))
                     {
                         logger.Debug($"Session pooled: {SfSession.sessionId}");