Remove public constructor

snowflakedb · Mar 25, 2024 · 3801171 · 3801171
1 parent e1c50b6
commit 3801171
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/Snowflake.Data.Tests/IntegrationTests/SFDbCommandIT.cs b/Snowflake.Data.Tests/IntegrationTests/SFDbCommandIT.cs
@@ -455,11 +455,13 @@ public async Task TestGetResultsOfUnknownQueryIdAsyncWithConfiguredRetry()
                 conn.ConnectionString = ConnectionString;
                 await conn.OpenAsync(CancellationToken.None).ConfigureAwait(false);
 
-                using (SnowflakeDbCommand cmd = new SnowflakeDbCommand(conn, new QueryResultsRetryConfig(queryResultsRetryCount, queryResultsRetryPattern)))
+                using (SnowflakeDbCommand cmd = (SnowflakeDbCommand)conn.CreateCommand())
                 {
+                    QueryResultsAwaiter queryResultsAwaiter = new QueryResultsAwaiter(new QueryResultsRetryConfig(queryResultsRetryCount, queryResultsRetryPattern));
+
                     // Act
                     var thrown = Assert.ThrowsAsync<Exception>(async () =>
-                        await cmd.GetResultsFromQueryIdAsync(unknownQueryId, CancellationToken.None).ConfigureAwait(false));
+                        await queryResultsAwaiter.RetryUntilQueryResultIsAvailable(conn, unknownQueryId, CancellationToken.None, true).ConfigureAwait(false));
 
                     // Assert
                     Assert.IsTrue(thrown.Message.Contains($"Max retry for no data is reached"));
@@ -1604,11 +1606,14 @@ public void TestGetResultsOfUnknownQueryIdWithConfiguredRetry()
             {
                 conn.ConnectionString = ConnectionString;
                 conn.Open();
-
-                using (SnowflakeDbCommand cmd = new SnowflakeDbCommand(conn, new QueryResultsRetryConfig(queryResultsRetryCount, queryResultsRetryPattern)))
+                using (SnowflakeDbCommand cmd = (SnowflakeDbCommand)conn.CreateCommand())
                 {
+                    // Arrange
+                    QueryResultsAwaiter queryResultsAwaiter = new QueryResultsAwaiter(new QueryResultsRetryConfig(queryResultsRetryCount, queryResultsRetryPattern));
+                    var task = queryResultsAwaiter.RetryUntilQueryResultIsAvailable(conn, unknownQueryId, CancellationToken.None, false);
+
                     // Act
-                    var thrown = Assert.Throws<AggregateException>(() => cmd.GetResultsFromQueryId(unknownQueryId));
+                    var thrown = Assert.Throws<AggregateException>(() => task.Wait());
 
                     // Assert
                     Assert.IsTrue(thrown.InnerException.Message.Contains($"Max retry for no data is reached"));

diff --git a/Snowflake.Data/Client/SnowflakeDbCommand.cs b/Snowflake.Data/Client/SnowflakeDbCommand.cs
@@ -44,11 +44,6 @@ public SnowflakeDbCommand(SnowflakeDbConnection connection, string cmdText) : th
             this.CommandText = cmdText;
         }
 
-        public SnowflakeDbCommand(SnowflakeDbConnection connection, QueryResultsRetryConfig queryResultsRetryConfig) : this(connection)
-        {
-            _queryResultsAwaiter = new QueryResultsAwaiter(queryResultsRetryConfig);
-        }
-
         public override string CommandText
         {
             get; set;