Task.FromResult should never be awaited -- you're waiting for nothing…

…. This only results in slowness and complexity for nothing.
snowflakedb · Dec 16, 2024 · 3496fac · 3496fac
1 parent 580da21
commit 3496fac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Snowflake.Data/Core/SFMultiStatementsResultSet.cs b/Snowflake.Data/Core/SFMultiStatementsResultSet.cs
@@ -1,4 +1,4 @@
-/*
+/*
  * Copyright (c) 2022 Snowflake Computing Inc. All rights reserved.
  */
 
@@ -72,7 +72,7 @@ internal override async Task<bool> NextResultAsync(CancellationToken cancellatio
             }
 
             updateResultMetadata();
-            return await Task.FromResult(curResultSet != null);
+            return curResultSet != null;
         }
 
         internal override bool NextResult()

diff --git a/Snowflake.Data/Core/SFResultSet.cs b/Snowflake.Data/Core/SFResultSet.cs
@@ -1,4 +1,4 @@
-/*
+/*
  * Copyright (c) 2012-2019 Snowflake Computing Inc. All rights reserved.
  */
 
@@ -157,9 +157,9 @@ internal override bool NextResult()
             return false;
         }
 
-        internal override async Task<bool> NextResultAsync(CancellationToken cancellationToken)
+        internal override Task<bool> NextResultAsync(CancellationToken cancellationToken)
         {
-            return await Task.FromResult(false);
+            return Task.FromResult(false);
         }
 
         internal override bool HasRows()