Skip to content

Commit

Permalink
SNOW-1271212 review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-mhofman committed Mar 29, 2024
1 parent dd9879f commit 1e85d52
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions Snowflake.Data.Tests/IntegrationTests/SFBindTestIT.cs
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ public void TestDateTimeBinding(ResultFormat resultFormat, SFTableType tableType
++row;
string faultMessage = $"Mismatch for row: {row}, {testCase}";
Assert.AreEqual(row, reader.GetInt32(0));
expected.IsEqual(reader.GetValue(1), comparisonFormat, faultMessage);
expected.AssertEqual(reader.GetValue(1), comparisonFormat, faultMessage);
}
}
Assert.AreEqual(1+smallBatchRowCount+bigBatchRowCount, row);
Expand Down Expand Up @@ -930,13 +930,13 @@ class ExpectedTimestampValueProvider
internal static ExpectedTimestampValueProvider From(string timestampWithTimeZone, SFDataType columnType)
{
if (IsOffsetType(columnType))
return new ExpectedTimestampValueProvider(DateTimeOffset.ParseExact(timestampWithTimeZone,
"yyyy/MM/dd HH:mm:ss.fff zzz",
CultureInfo.InvariantCulture), columnType);
return new ExpectedTimestampValueProvider(DateTime.ParseExact(timestampWithTimeZone,
"yyyy/MM/dd HH:mm:ss.fff zzz",
CultureInfo.InvariantCulture), columnType);
{
var dateTimeOffset = DateTimeOffset.ParseExact(timestampWithTimeZone, "yyyy/MM/dd HH:mm:ss.fff zzz", CultureInfo.InvariantCulture);
return new ExpectedTimestampValueProvider(dateTimeOffset, columnType);
}

var dateTime = DateTime.ParseExact(timestampWithTimeZone, "yyyy/MM/dd HH:mm:ss.fff zzz", CultureInfo.InvariantCulture);
return new ExpectedTimestampValueProvider(dateTime, columnType);
}

private ExpectedTimestampValueProvider(DateTime dateTime, SFDataType columnType)
Expand All @@ -955,7 +955,7 @@ private ExpectedTimestampValueProvider(DateTimeOffset dateTimeOffset, SFDataType

internal SFDataType ExpectedColumnType() => _columnType;

internal void IsEqual(object actual, string comparisonFormat, string faultMessage)
internal void AssertEqual(object actual, string comparisonFormat, string faultMessage)
{
switch (_columnType)
{
Expand Down

0 comments on commit 1e85d52

Please sign in to comment.